Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency: abraham/twitteroauth to v1.2.0 #122

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Update dependency: abraham/twitteroauth to v1.2.0 #122

merged 3 commits into from
Mar 5, 2021
+97 −41

Conversation

thrijith
Copy link
Member

Description of the Change

  • Updates twitter oauth library to v1.2.0 for PHP 7.4 support

Possible Drawbacks

  • Drops support for sites on PHP version less than 7.2

Verification Process

  • Tested auto tweet with and without featured image, more details here.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #119

Changelog Entry

  • Update Twitter OAuth library to v1.2.0
  • Bumps Required PHP version to be 7.2

@thrijith thrijith requested a review from jeffpaul February 12, 2021 21:24
@thrijith
Copy link
Member Author

@jeffpaul I've removed tests for older version as well from the workflow, please let me know if that works, thanks!

b09f5a8

@jeffpaul jeffpaul requested a review from dinhtungdu February 12, 2021 22:11
@jeffpaul jeffpaul added this to the 1.0.5 milestone Feb 12, 2021
dinhtungdu
dinhtungdu approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working. Post with our without featured image is tweeted as expected.

@jeffpaul jeffpaul merged commit 1127578 into develop Mar 5, 2021
@jeffpaul jeffpaul deleted the feature/php-7-4-update branch April 21, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees

@thrijith thrijith

Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

PHP 7.4 Support
3 participants
@thrijith @dinhtungdu @jeffpaul